fix(verifier): drain runtime queue jobs#102
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates Location.from_dict to cast line_end to an integer to support DynamoDB Decimal types, and modifies lease_next_scan_job to filter out 'verify' jobs from the leased candidates, accompanied by relevant unit tests. Feedback on these changes suggests implementing defensive type coercion when parsing line_end to prevent potential crashes on malformed input. Additionally, there is a concern regarding head-of-line blocking and queue starvation, as filtering 'verify' jobs in-memory after querying a bounded candidate window could exhaust the retrieved window and starve standard scan jobs.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
What
Fixes the runtime verifier queue drain path for DynamoDB-backed queue payloads.
Why
Historical verifier backfill can enqueue DB-backed verifier jobs, but the drain path was blocked by two runtime issues:
job_type="verify"queue entries and return them to pending, competing withverify-drain.Changes
Location.lineEndduring finding deserialization, matching existinglineStarthandling.lease_next_scan_job()so onlylease_next_verify_job()consumes them.Validation
Closes #101